Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Box.update()rejects a valid positional source together with keyword overrides:The current call raises
BoxTypeError: update expected at most 1 argument, got 2because the arity guard counts the keyword argument set as another positional source. This patch counts only positional sources. The existing update loops already apply source values before keyword values, preserving the expected override order. It also adds regressions, an unreleased changelog entry, and contributor credit.Validation
git diff --check: passed.Validation ran on macOS with Python 3.12.15; the other supported interpreter/platform and wheel matrix remains for CI.
AI assistance was used to prepare the implementation and regression tests.